Skip to content

Visit callable objects#51

Open
jakobjpeters wants to merge 1 commit intotimholy:masterfrom
jakobjpeters:master
Open

Visit callable objects#51
jakobjpeters wants to merge 1 commit intotimholy:masterfrom
jakobjpeters:master

Conversation

@jakobjpeters
Copy link

Closes #50.

@timholy
Copy link
Owner

timholy commented Jul 7, 2025

Sorry I didn't see this earlier. It's a nice idea, but I do worry about the unrestricted signature for x: this replaces the default "do-nothing" fallback with a method that tries to do something.

I wonder if rather than relying on dispatching the callee, what if we put a check for !isempty(methods(x)) && _visit(...) in the caller of the method you've written?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect dispatch on Base.Callable

2 participants